So if the PR is closed, has it been merged? How do we know the status of the closed ones as it pertains to master?
Also: What is the timeline for when a request is merged to master? I am not a programmer by trade, and often times, if stuff works for me, it does despite my actions rather than because of them, thus I like simplicity :) On Thu, Jul 16, 2015 at 8:16 AM, moon soo Lee <m...@apache.org> wrote: > Hi, > > Usually open pull requests means not merged to master yet. So you will > need checkout particular branch in the pull request to try something in the > pullrequest that is still open. > > https://gist.github.com/Leemoonsoo/d673d7357f881538dab4 is simple script > that i use for testing a branch. > > for example, for pullrequest 101 > > git checkout -b pr101 > ./test.py 101 > > will merge pullrequest 101 to local branch 'pr101' > > > Green check box is CI test status, no direct relation to open/close status > of pullrequests, but usually green CI status is one requirement to be > merged. > > Hope this helps. > > Thanks, > moon > > On Thu, Jul 16, 2015 at 5:47 AM John Omernik <j...@omernik.com> wrote: > >> Thank you so much Moon! >> >> I have a few questions on how Github works. So these pull requests. I >> see some have a red X some have a green check. Also, there are Open pull >> requests and Closed pull requests. >> >> So... >> If I do a standard git clone of master, which pull requests will be >> included in my pull? >> >> For example? Open pulls that have a green check and all closed? Only >> closed requests (when a request is closed, is it merged?)? Or only closed >> requests that have a green check. (Some closed requests have a red X too). >> I know there will be many who read my post and point and laugh, and I am >> ok with that :) Especially if there are any out there who may be helped by >> that answer. >> >> So, I guess the question is, since the pull 110 (for the drill >> interpreter) is Open and has a green check mark, will it be in the git >> clone or do I have to do something to include it? Follow-up question: Are >> closed pulls always merged or only if the green check box is there? >> >> Thanks for the answers in advance (we can call this Git Hub 101) :) >> >> john >> >> >> >> On Wed, Jul 15, 2015 at 10:41 PM, moon soo Lee <m...@apache.org> wrote: >> >>> Hi, >>> >>> Here's working drill interpreter >>> https://github.com/apache/incubator-zeppelin/pull/110 by pfcurtis. >>> >>> Thanks, >>> moon >>> >>> On Wed, Jul 15, 2015 at 12:05 PM John Omernik <j...@omernik.com> wrote: >>> >>>> Anyone working on a drill interpreter? >>>> >>> >>
