There is a dangling reference to split-sequence but split-sequence
itself is no longer
marked as a dependency in the defsystem spec. This means that usocket cannot
currently be loaded using asdf unless split-sequence has already been loaded by
some other system.
The attached patch just replaces calls to
split-sequence:split-sequence with corresponding
calls to cl-utilities:split-sequence.
Also I think a few of the tests might need to be rewritten. Both
before and after
applying this patch, 6 out of 15 tests fail for me.
Regards,
Andy Chambers
(format t "type: ~a version: ~a"
(lisp-implementation-type)
(lisp-implementation-version))
type: SBCL version: 1.0.18.debian
(usocket-test:run-usocket-tests)
Doing 15 pending tests of 15 tests total.
USOCKET-TEST::MAKE-SOCKET.1 USOCKET-TEST::MAKE-SOCKET.2
#<USOCKET:UNSUPPORTED {B075EB9}>
is a USOCKET:UNSUPPORTED.
Its slot values are
(:FEATURE USOCKET::TIMEOUT :CONTEXT USOCKET:SOCKET-CONNECT :MINIMUM NIL).
Test USOCKET-TEST::SOCKET-NO-CONNECT.1 failed
Form: (USOCKET-TEST::WITH-CAUGHT-CONDITIONS ('USOCKET:SOCKET-ERROR NIL)
(USOCKET:SOCKET-CONNECT
"127.0.0.0"
USOCKET-TEST::+UNUSED-LOCAL-PORT+
:TIMEOUT 0)
T)
Expected value: NIL
Actual value: #<USOCKET:UNSUPPORTED {B075EB9}>.
#<USOCKET:UNSUPPORTED {B20A2B1}>
is a USOCKET:UNSUPPORTED.
Its slot values are
(:FEATURE USOCKET::TIMEOUT :CONTEXT USOCKET:SOCKET-CONNECT :MINIMUM NIL).
Test USOCKET-TEST::SOCKET-NO-CONNECT.2 failed
Form: (USOCKET-TEST::WITH-CAUGHT-CONDITIONS ('USOCKET:SOCKET-ERROR NIL)
(USOCKET:SOCKET-CONNECT
#(127 0 0 0)
USOCKET-TEST::+UNUSED-LOCAL-PORT+
:TIMEOUT 0)
T)
Expected value: NIL
Actual value: #<USOCKET:UNSUPPORTED {B20A2B1}>.
#<USOCKET:UNSUPPORTED {B3A5D81}>
is a USOCKET:UNSUPPORTED.
Its slot values are
(:FEATURE USOCKET::TIMEOUT :CONTEXT USOCKET:SOCKET-CONNECT :MINIMUM NIL).
Test USOCKET-TEST::SOCKET-NO-CONNECT.3 failed
Form: (USOCKET-TEST::WITH-CAUGHT-CONDITIONS ('USOCKET:SOCKET-ERROR NIL)
(USOCKET:SOCKET-CONNECT
2130706432
USOCKET-TEST::+UNUSED-LOCAL-PORT+
:TIMEOUT 0)
T)
Expected value: NIL
Actual value: #<USOCKET:UNSUPPORTED {B3A5D81}>.
#<USOCKET:UNSUPPORTED {B5461D9}>
is a USOCKET:UNSUPPORTED.
Its slot values are
(:FEATURE USOCKET::TIMEOUT :CONTEXT USOCKET:SOCKET-CONNECT :MINIMUM NIL).
Test USOCKET-TEST::SOCKET-FAILURE.1 failed
Form: (USOCKET-TEST::WITH-CAUGHT-CONDITIONS
('USOCKET:NETWORK-UNREACHABLE-ERROR NIL)
(USOCKET:SOCKET-CONNECT 2130706432
USOCKET-TEST::+UNUSED-LOCAL-PORT+ :TIMEOUT
0)
:UNREACH)
Expected value: NIL
Actual value: #<USOCKET:UNSUPPORTED {B5461D9}>.
#<USOCKET:UNSUPPORTED {B9C8229}>
is a USOCKET:UNSUPPORTED.
Its slot values are
(:FEATURE USOCKET::TIMEOUT :CONTEXT USOCKET:SOCKET-CONNECT :MINIMUM NIL).
Test USOCKET-TEST::SOCKET-FAILURE.2 failed
Form: (USOCKET-TEST::WITH-CAUGHT-CONDITIONS
('USOCKET:HOST-UNREACHABLE-ERROR NIL)
(USOCKET:SOCKET-CONNECT USOCKET-TEST::+NON-EXISTING-HOST+ 80
:TIMEOUT 0)
:UNREACH)
Expected value: NIL
Actual value: #<USOCKET:UNSUPPORTED {B9C8229}>.
USOCKET-TEST::SOCKET-CONNECT.1 USOCKET-TEST::SOCKET-CONNECT.2
USOCKET-TEST::SOCKET-CONNECT.3 USOCKET-TEST::SOCKET-STREAM.1
USOCKET-TEST::SOCKET-NAME.1 USOCKET-TEST::SOCKET-NAME.2
USOCKET-TEST::SOCKET-NAME.3
Test USOCKET-TEST::SOCKET-NAME.4 failed
Form: (USOCKET-TEST::WITH-CAUGHT-CONDITIONS (NIL NIL)
(LET ((USOCKET-TEST::SOCK
(USOCKET:SOCKET-CONNECT
USOCKET-TEST::+COMMON-LISP-NET+
80)))
(UNWIND-PROTECT
(USOCKET:GET-LOCAL-ADDRESS
USOCKET-TEST::SOCK)
(USOCKET:SOCKET-CLOSE
USOCKET-TEST::SOCK))))
Expected value: #(192 168 1 25)
Actual value: #(192 168 0 3).
6 out of 15 total tests failed: USOCKET-TEST::SOCKET-NO-CONNECT.1,
USOCKET-TEST::SOCKET-NO-CONNECT.2, USOCKET-TEST::SOCKET-NO-CONNECT.3,
USOCKET-TEST::SOCKET-FAILURE.1, USOCKET-TEST::SOCKET-FAILURE.2,
USOCKET-TEST::SOCKET-NAME.4.
NIL
CL-USER>
--
----
Andy Chambers
Formedix Ltd
Index: usocket.lisp
===================================================================
--- usocket.lisp (revision 517)
+++ usocket.lisp (working copy)
@@ -399,14 +399,14 @@
(aref vector 3)))
(defun dotted-quad-to-vector-quad (string)
- (let ((list (list-of-strings-to-integers (split-sequence:split-sequence #\. string))))
+ (let ((list (list-of-strings-to-integers (cl-utilities:split-sequence #\. string))))
(vector (first list) (second list) (third list) (fourth list))))
(defgeneric host-byte-order (address))
(defmethod host-byte-order ((string string))
"Convert a string, such as 192.168.1.1, to host-byte-order,
such as 3232235777."
- (let ((list (list-of-strings-to-integers (split-sequence:split-sequence #\. string))))
+ (let ((list (list-of-strings-to-integers (cl-utilities:split-sequence #\. string))))
(+ (* (first list) 256 256 256) (* (second list) 256 256)
(* (third list) 256) (fourth list))))
_______________________________________________
usocket-devel mailing list
[email protected]
http://common-lisp.net/cgi-bin/mailman/listinfo/usocket-devel
