Hi Olaf,
On Wed, Aug 15, 2007 at 09:10:53PM +0200, Olaf Hering wrote:
> On Wed, May 09, Karel Zak wrote:
>
> > The NFS client code in util-linux-ng is dead. Don't forget to install
>
> I havent check the sources, but mount handles fstype "nfs" just like
> "ext2" or similar if mount.nfs is not installed.
what do you mean with "like ext2"?
# mount localhost:/mnt/store /mnt/test
strace output:
stat("/sbin/mount.nfs", 0x7fff27169340) = -1 ENOENT (No such file or directory)
mount("localhost:/mnt/store", "/mnt/test", "nfs", MS_MGC_VAL, NULL) = -1
EINVAL (Invalid argument)
^^^^^
it explicitly uses filesystemtype="nfs" and the data=NULL.
> Please dont do that.
> nfs_validate_mount_data() expects a properly initialized struct
> nfs_mount_data,
> not random memory.
It's really kernel job to check incoming data. I don't think we have
to hardcode any NFS specific check to every util where is mount(2)
syscall.
> Can you please fix this for upcoming versions for mount?
Why? I don't see a problem, my 2.6.20 kernel returns EINVAL. Isn't it right?
Karel
--
Karel Zak <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
