On Thu, Apr 02, 2009 at 05:44:50PM -0700, Roland McGrath wrote: >> The patch only implements it for "server/classic" processors, not BookE, >> thus it should probably only advertise it for these :-) >> >> Though it wouldn't be too hard to implement it for BookE using DBCR0:BRT >> (Branch Taken debug event) though it might need some careful fixups such >> as the one we have for single step regarding hitting exception entry >> code. > >In that case, this code seems fairly mysterious: > >> > +#if defined(CONFIG_40x) || defined(CONFIG_BOOKE) >> > + task->thread.dbcr0 = DBCR0_IDM | DBCR0_BT; >> > + regs->msr |= MSR_DE; > >That doesn't already do whatever it is you described? > >Can we assume now that you or someone else who knows what all that means >will take this up?
I will try and look at the patch a bit more tomorrow, yes. I don't think having it working for BookE is really a requirement before this gets in though. If we can get it working with minimal effort for ppc64, that would help get systemtap and related things functioning correctly there. While I would love to believe that systemtap should work everywhere, I can't really see it running on an embedded board at this point. josh
