Etienne,

I'm not sure what you have done, but if you look at your own
pull-request you will notice:

- it is *massive*: 250+ commits, 149 files changed. I don't think that
is what you want to achieve :-)

- it should probably contain a single commit:

https://github.com/tkadm30/uwsgi/commit/6e0af72311b4af2a6f6c391edbca9488eb2d0a7a

as present on your 2.0.16-pypi branch.

I think what you did was prepare a branch off of the 2.0 branch, but
requested a merge with the master branch. That would explain the messy
pull request.










On 26-02-18 20:25, Etienne Robillard wrote:
> Thanks Paul. I managed to create a pull request:
> https://github.com/unbit/uwsgi/pull/1751
> 
> Please let me know what you think.
> 
> Etienne
> 
> 
> Le 2018-02-26 à 05:58, Paul J Stevens a écrit :
>> On 25-02-18 19:18, Etienne Robillard wrote:
>>> I'm afraid I don't know how to make a pull requests.
>> To create a pull-request, you first need a github account.
>>
>> While logged into your account:
>>
>> - navigate to the uwsgi repository https://github.com/unbit/uwsgi/
>> - click on 'Fork' and follow the steps indicated to create a copy of the
>> uwsgi code in your own github account
>> - click on the 'Clone or download' while you're in your own account's
>> copy
>> - clone your fork to your workstation
>> - edit the source-code
>> - commit and push
>>
>>
>> follow the steps:
>>
>> https://help.github.com/articles/creating-a-pull-request/#creating-the-pull-request
>>
>>
>>
>>
>>
>>
>>
>>
>>
> 


-- 
Lab Digital
Paul J Stevens | Systems Engineering
M: +31 (0)62 460 6876
T: +31 (0)85 060 3980
Kanaalweg 14-G, 3526 KL Utrecht
_______________________________________________
uWSGI mailing list
uWSGI@lists.unbit.it
http://lists.unbit.it/cgi-bin/mailman/listinfo/uwsgi

Reply via email to