lgtm On Mon, Sep 8, 2008 at 8:52 AM, <[EMAIL PROTECTED]> wrote: > Christian, > > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL > PROTECTED] > > Alternatively, to review the latest snapshot of this change > branch, run > > gvn --project https://v8.googlecode.com/svn review [EMAIL > PROTECTED]/fix-issues-28-30 > > to review the following change: > > [EMAIL PROTECTED]/[EMAIL PROTECTED] | [EMAIL PROTECTED] | 2008-09-08 07:51:44 > +-100 (Mon, 08 Sep 2008) > > Description: > > Fix issues 28 and 30 by changed the header guard to V8_H_ and > including HandleScope::ZapRange in release mode. > > > > Affected Paths: > M //branches/bleeding_edge/include/v8.h > M //branches/bleeding_edge/src/api.cc > > > This is a semiautomated message from "gvn mail". See > <http://code.google.com/p/gvn/> to learn more. > > Index: include/v8.h > =================================================================== > --- include/v8.h (^/branches/bleeding_edge/include/[EMAIL PROTECTED]) > +++ include/v8.h (^/changes/[EMAIL > PROTECTED]/fix-issues-28-30/bleeding_edge/include/[EMAIL PROTECTED]) > @@ -35,8 +35,8 @@ > * For other documentation see http://code.google.com/apis/v8/ > */ > > -#ifndef _V8 > -#define _V8 > +#ifndef V8_H_ > +#define V8_H_ > > #include <stdio.h> > > @@ -461,10 +461,8 @@ class EXPORT HandleScope { > /** Deallocates any extensions used by the current scope.*/ > static void DeleteExtensions(); > > -#ifdef DEBUG > // Zaps the handles in the half-open interval [start, end). > static void ZapRange(void** start, void** end); > -#endif > > friend class ImplementationUtilities; > }; > @@ -2311,4 +2309,4 @@ void Template::Set(const char* name, v8::Handle<Da > #undef TYPE_CHECK > > > -#endif // _V8 > +#endif // ifndef V8_H_ > Index: src/api.cc > =================================================================== > --- src/api.cc (^/branches/bleeding_edge/src/[EMAIL PROTECTED]) > +++ src/api.cc (^/changes/[EMAIL > PROTECTED]/fix-issues-28-30/bleeding_edge/src/[EMAIL PROTECTED]) > @@ -446,14 +446,12 @@ void v8::HandleScope::DeleteExtensions() { > } > > > -#ifdef DEBUG > void HandleScope::ZapRange(void** start, void** end) { > if (start == NULL) return; > for (void** p = start; p < end; p++) { > *p = reinterpret_cast<void*>(v8::internal::kHandleZapValue); > } > } > -#endif > > > void** v8::HandleScope::RawClose(void** value) { > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
