LGTM On Mon, Sep 8, 2008 at 8:57 AM, <[EMAIL PROTECTED]> wrote: > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL > PROTECTED] > > Alternatively, to review the latest snapshot of this change > branch, run > > gvn --project https://v8.googlecode.com/svn review [EMAIL > PROTECTED]/cat-and-test-status > > to review the following change: > > [EMAIL PROTECTED]/[EMAIL PROTECTED] | [EMAIL PROTECTED] | 2008-09-08 07:55:54 > +-100 (Mon, 08 Sep 2008) > > Description: > > - Marked flaky windows gc test as flaky. > - Added support for --cat in test runner. > > > > > Affected Paths: > M //branches/bleeding_edge/test/mjsunit/testcfg.py > M //branches/bleeding_edge/test/mozilla/mozilla.status > M //branches/bleeding_edge/test/mozilla/testcfg.py > M //branches/bleeding_edge/tools/test.py > > > This is a semiautomated message from "gvn mail". See > <http://code.google.com/p/gvn/> to learn more. > > Index: test/mjsunit/testcfg.py > =================================================================== > --- test/mjsunit/testcfg.py (^/branches/bleeding_edge/test/mjsunit/[EMAIL > PROTECTED]) > +++ test/mjsunit/testcfg.py (^/changes/[EMAIL > PROTECTED]/cat-and-test-status/bleeding_edge/test/mjsunit/[EMAIL PROTECTED]) > @@ -58,7 +58,10 @@ class MjsunitTestCase(test.TestCase): > result += [framework, self.file] > return result > > + def GetSource(self): > + return open(self.file).read() > > + > class MjsunitTestConfiguration(test.TestConfiguration): > > def __init__(self, context, root): > Index: test/mozilla/mozilla.status > =================================================================== > --- test/mozilla/mozilla.status (^/branches/bleeding_edge/test/mozilla/[EMAIL > PROTECTED]) > +++ test/mozilla/mozilla.status (^/changes/[EMAIL > PROTECTED]/cat-and-test-status/bleeding_edge/test/mozilla/[EMAIL PROTECTED]) > @@ -752,6 +752,7 @@ js1_5/decompilation/regress-406555: PASS || FAIL > > # This test is flaky because of the default timer resolution on Windows. > js1_5/extensions/regress-363258: PASS || FAIL > +mozilla/js1_5/GC/regress-383269-02: PASS, FLAKY IF $mode == debug > > [ $FAST == yes ] > > Index: test/mozilla/testcfg.py > =================================================================== > --- test/mozilla/testcfg.py (^/branches/bleeding_edge/test/mozilla/[EMAIL > PROTECTED]) > +++ test/mozilla/testcfg.py (^/changes/[EMAIL > PROTECTED]/cat-and-test-status/bleeding_edge/test/mozilla/[EMAIL PROTECTED]) > @@ -82,7 +82,10 @@ class MozillaTestCase(test.TestCase): > def GetName(self): > return self.path[-1] > > + def GetSource(self): > + return open(self.filename).read() > > + > class MozillaTestConfiguration(test.TestConfiguration): > > def __init__(self, context, root): > Index: tools/test.py > =================================================================== > --- tools/test.py (^/branches/bleeding_edge/tools/[EMAIL PROTECTED]) > +++ tools/test.py (^/changes/[EMAIL > PROTECTED]/cat-and-test-status/bleeding_edge/tools/[EMAIL PROTECTED]) > @@ -259,6 +259,9 @@ class TestCase(object): > def IsFailureOutput(self, output): > return output.exit_code != 0 > > + def GetSource(self): > + return "(no source available)" > + > def Run(self): > command = self.GetCommand() > full_command = self.context.processor(command) > @@ -948,6 +951,8 @@ def BuildOptions(): > result.add_option("--arch", help='The architecture to run tests for', > default=ARCH_GUESS) > result.add_option("--special-command", default=None) > + result.add_option("--cat", help="Print the source of the tests", > + default=False, action="store_true") > return result > > > @@ -1069,6 +1074,7 @@ def Main(): > # List the tests > all_cases = [ ] > all_unused = [ ] > + unclassified_tests = [ ] > for path in paths: > for mode in options.mode: > env = { > @@ -1077,10 +1083,24 @@ def Main(): > 'arch': options.arch > } > test_list = root.ListTests([], path, context, mode) > + unclassified_tests += test_list > (cases, unused_rules) = config.ClassifyTests(test_list, env) > all_cases += cases > all_unused.append(unused_rules) > > + if options.cat: > + visited = set() > + for test in unclassified_tests: > + key = tuple(test.path) > + if key in visited: > + continue > + visited.add(key) > + print "--- begin source: %s ---" % test.GetLabel() > + source = test.GetSource().strip() > + print source > + print "--- end source: %s ---" % test.GetLabel() > + return 0 > + > # for rule in unused_rules: > # print "Rule for '%s' was not used." % '/'.join([str(s) for s in > rule.path]) > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
