LGTM On Mon, Sep 8, 2008 at 11:26 AM, <[EMAIL PROTECTED]> wrote: > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL > PROTECTED] > > Alternatively, to review the latest snapshot of this change > branch, run > > gvn --project https://v8.googlecode.com/svn review [EMAIL > PROTECTED]/asian-letters > > to review the following change: > > [EMAIL PROTECTED]/[EMAIL PROTECTED] | [EMAIL PROTECTED] | 2008-09-08 10:25:18 > +-100 (Mon, 08 Sep 2008) > > Description: > > Fixed problem where asian characters were not categorized as letters > because they were defined using different syntax in the unicode > database. > > > > > Affected Paths: > M //branches/bleeding_edge/src/unicode-inl.h > M //branches/bleeding_edge/src/unicode.cc > M //branches/bleeding_edge/src/unicode.h > D //branches/bleeding_edge/test/mjsunit/bugs/bug-1346700.js > A //branches/bleeding_edge/test/mjsunit/regress/regress-1346700.js > > > This is a semiautomated message from "gvn mail". See > <http://code.google.com/p/gvn/> to learn more. > > Index: src/unicode-inl.h > =================================================================== > --- src/unicode-inl.h (^/branches/bleeding_edge/src/[EMAIL PROTECTED]) > +++ src/unicode-inl.h (^/changes/[EMAIL > PROTECTED]/asian-letters/bleeding_edge/src/[EMAIL PROTECTED]) > @@ -1,4 +1,4 @@ > -// Copyright 2007-2008 Google Inc. All Rights Reserved. > +// Copyright 2007-2008 the V8 authors. All rights reserved. > // Redistribution and use in source and binary forms, with or without > // modification, are permitted provided that the following conditions are > // met: > Index: src/unicode.cc > =================================================================== > --- src/unicode.cc (^/branches/bleeding_edge/src/[EMAIL PROTECTED]) > +++ src/unicode.cc (^/changes/[EMAIL > PROTECTED]/asian-letters/bleeding_edge/src/[EMAIL PROTECTED]) > @@ -1,4 +1,4 @@ > -// Copyright 2007-2008 Google Inc. All Rights Reserved. > +// Copyright 2007-2008 the V8 authors. All rights reserved. > // Redistribution and use in source and binary forms, with or without > // modification, are permitted provided that the following conditions are > // met: > @@ -25,7 +25,7 @@ > // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > // > -// This file was generated at 2008-06-12 16:11:05.556081 > +// This file was generated at 2008-09-08 11:13:45.862026 > > #include "unicode-inl.h" > #include <cstdlib> > @@ -380,18 +380,18 @@ bool Lowercase::Is(uchar c) { > > // Letter: point.category in ['Lu', 'Ll', 'Lt', 'Lm', 'Lo' ] > > -static const uint16_t kLetterTable0Size = 475; > -static const uint16_t kLetterTable0[475] = { 32833, 90, 32865, 122, 170, > 181, 186, 32960, 214, 32984, 246, 33016, 705, 33478, 721, 33504, 740, 750, > 33658, 893, 902, 33672, 906, 908, 33678, 929, 33699, 974, 33744, 1013, 33783, > 1153, 33930, 1299, 34097, 1366, 1369, 34145, 1415, 34256, 1514, 34288, 1522, > 34337, 1594, 34368, 1610, 34414, 1647, 34417, 1747, 1749, 34533, 1766, 34542, > 1775, 34554, 1788, 1791, 1808, 34578, 1839, 34637, 1901, 34688, 1957, 1969, > 34762, 2026, 34804, 2037, 2042, 35076, 2361, 2365, 2384, 35160, 2401, 35195, > 2431, 35205, 2444, 35215, 2448, 35219, 2472, 35242, 2480, 2482, 35254, 2489, > 2493, 2510, 35292, 2525, 35295, 2529, 35312, 2545, 35333, 2570, 35343, 2576, > 35347, 2600, 35370, 2608, 35378, 2611, 35381, 2614, 35384, 2617, 35417, 2652, > 2654, 35442, 2676, 35461, 2701, 35471, 2705, 35475, 2728, 35498, 2736, 35506, > 2739, 35509, 2745, 2749, 2768, 35552, 2785, 35589, 2828, 35599, 2832, 35603, > 2856, 35626, 2864, 35634, 2867, 35637, 2873, 2877, 35676, 2909, 3! 56! > 79, 2913, 2929, 2947, 35717, 2954, 35726, 2960, 35730, 2965, 35737, 2970, > 2972, 35742, 2975, 35747, 2980, 35752, 2986, 35758, 3001, 35845, 3084, 35854, > 3088, 35858, 3112, 35882, 3123, 35893, 3129, 35936, 3169, 35973, 3212, 35982, > 3216, 35986, 3240, 36010, 3251, 36021, 3257, 3261, 3294, 36064, 3297, 36101, > 3340, 36110, 3344, 36114, 3368, 36138, 3385, 36192, 3425, 36229, 3478, 36250, > 3505, 36275, 3515, 3517, 36288, 3526, 36353, 3632, 36402, 3635, 36416, 3654, > 36481, 3714, 3716, 36487, 3720, 3722, 3725, 36500, 3735, 36505, 3743, 36513, > 3747, 3749, 3751, 36522, 3755, 36525, 3760, 36530, 3763, 3773, 36544, 3780, > 3782, 36572, 3805, 3840, 36672, 3911, 36681, 3946, 36744, 3979, 36864, 4129, > 36899, 4135, 36905, 4138, 36944, 4181, 37024, 4293, 37072, 4346, 4348, 37120, > 4441, 37215, 4514, 37288, 4601, 37376, 4680, 37450, 4685, 37456, 4694, 4696, > 37466, 4701, 37472, 4744, 37514, 4749, 37520, 4784, 37554, 4789, 37560, 4798, > 4800, 37570, 4805, 37576, 4822, 37592, 4880, 37650, 4885, 376! 56! > , 4954, 37760, 5007, 37792, 5108, 37889, 5740, 38511, 5750, 38529, 578 > 6, 38560, 5866, 38656, 5900, 38670, 5905, 38688, 5937, 38720, 5969, 38752, > 5996, 38766, 6000, 38784, 6067, 6103, 6108, 38944, 6263, 39040, 6312, 39168, > 6428, 39248, 6509, 39280, 6516, 39296, 6569, 39361, 6599, 39424, 6678, 39685, > 6963, 39749, 6987, 40192, 7615, 40448, 7835, 40608, 7929, 40704, 7957, 40728, > 7965, 40736, 8005, 40776, 8013, 40784, 8023, 8025, 8027, 8029, 40799, 8061, > 40832, 8116, 40886, 8124, 8126, 40898, 8132, 40902, 8140, 40912, 8147, 40918, > 8155, 40928, 8172, 40946, 8180, 40950, 8188, 8305, 8319, 41104, 8340, 8450, > 8455, 41226, 8467, 8469, 41241, 8477, 8484, 8486, 8488, 41258, 8493, 41263, > 8505, 41276, 8511, 41285, 8521, 8526, 41347, 8580, 44032, 11310, 44080, > 11358, 44128, 11372, 44148, 11383, 44160, 11492, 44288, 11557, 44336, 11621, > 11631, 44416, 11670, 44448, 11686, 44456, 11694, 44464, 11702, 44472, 11710, > 44480, 11718, 44488, 11726, 44496, 11734, 44504, 11742, 45061, 12294, 45105, > 12341, 45115, 12348, 45121, 12438, 45213, 12447, 45217, 12538, 45308, ! 12! > 543, 45317, 12588, 45361, 12686, 45472, 12727, 45552, 12799, 13312, 19893, > 19968 }; // NOLINT > -static const uint16_t kLetterTable1Size = 67; > -static const uint16_t kLetterTable1[67] = { 8123, 40960, 9356, 42775, 10010, > 43008, 10241, 43011, 10245, 43015, 10250, 43020, 10274, 43072, 10355, 11264, > 22435, 63744, 31277, 64048, 31338, 64112, 31449, 64256, 31494, 64275, 31511, > 31517, 64287, 31528, 64298, 31542, 64312, 31548, 31550, 64320, 31553, 64323, > 31556, 64326, 31665, 64467, 32061, 64848, 32143, 64914, 32199, 65008, 32251, > 65136, 32372, 65142, 32508, 65313, 32570, 65345, 32602, 65382, 32702, 65474, > 32711, 65482, 32719, 65490, 32727, 65498, 32732 }; // NOLINT > +static const uint16_t kLetterTable0Size = 476; > +static const uint16_t kLetterTable0[476] = { 32833, 90, 32865, 122, 170, > 181, 186, 32960, 214, 32984, 246, 33016, 705, 33478, 721, 33504, 740, 750, > 33658, 893, 902, 33672, 906, 908, 33678, 929, 33699, 974, 33744, 1013, 33783, > 1153, 33930, 1299, 34097, 1366, 1369, 34145, 1415, 34256, 1514, 34288, 1522, > 34337, 1594, 34368, 1610, 34414, 1647, 34417, 1747, 1749, 34533, 1766, 34542, > 1775, 34554, 1788, 1791, 1808, 34578, 1839, 34637, 1901, 34688, 1957, 1969, > 34762, 2026, 34804, 2037, 2042, 35076, 2361, 2365, 2384, 35160, 2401, 35195, > 2431, 35205, 2444, 35215, 2448, 35219, 2472, 35242, 2480, 2482, 35254, 2489, > 2493, 2510, 35292, 2525, 35295, 2529, 35312, 2545, 35333, 2570, 35343, 2576, > 35347, 2600, 35370, 2608, 35378, 2611, 35381, 2614, 35384, 2617, 35417, 2652, > 2654, 35442, 2676, 35461, 2701, 35471, 2705, 35475, 2728, 35498, 2736, 35506, > 2739, 35509, 2745, 2749, 2768, 35552, 2785, 35589, 2828, 35599, 2832, 35603, > 2856, 35626, 2864, 35634, 2867, 35637, 2873, 2877, 35676, 2909, 3! 56! > 79, 2913, 2929, 2947, 35717, 2954, 35726, 2960, 35730, 2965, 35737, 2970, > 2972, 35742, 2975, 35747, 2980, 35752, 2986, 35758, 3001, 35845, 3084, 35854, > 3088, 35858, 3112, 35882, 3123, 35893, 3129, 35936, 3169, 35973, 3212, 35982, > 3216, 35986, 3240, 36010, 3251, 36021, 3257, 3261, 3294, 36064, 3297, 36101, > 3340, 36110, 3344, 36114, 3368, 36138, 3385, 36192, 3425, 36229, 3478, 36250, > 3505, 36275, 3515, 3517, 36288, 3526, 36353, 3632, 36402, 3635, 36416, 3654, > 36481, 3714, 3716, 36487, 3720, 3722, 3725, 36500, 3735, 36505, 3743, 36513, > 3747, 3749, 3751, 36522, 3755, 36525, 3760, 36530, 3763, 3773, 36544, 3780, > 3782, 36572, 3805, 3840, 36672, 3911, 36681, 3946, 36744, 3979, 36864, 4129, > 36899, 4135, 36905, 4138, 36944, 4181, 37024, 4293, 37072, 4346, 4348, 37120, > 4441, 37215, 4514, 37288, 4601, 37376, 4680, 37450, 4685, 37456, 4694, 4696, > 37466, 4701, 37472, 4744, 37514, 4749, 37520, 4784, 37554, 4789, 37560, 4798, > 4800, 37570, 4805, 37576, 4822, 37592, 4880, 37650, 4885, 376! 56! > , 4954, 37760, 5007, 37792, 5108, 37889, 5740, 38511, 5750, 38529, 578 > 6, 38560, 5866, 38656, 5900, 38670, 5905, 38688, 5937, 38720, 5969, 38752, > 5996, 38766, 6000, 38784, 6067, 6103, 6108, 38944, 6263, 39040, 6312, 39168, > 6428, 39248, 6509, 39280, 6516, 39296, 6569, 39361, 6599, 39424, 6678, 39685, > 6963, 39749, 6987, 40192, 7615, 40448, 7835, 40608, 7929, 40704, 7957, 40728, > 7965, 40736, 8005, 40776, 8013, 40784, 8023, 8025, 8027, 8029, 40799, 8061, > 40832, 8116, 40886, 8124, 8126, 40898, 8132, 40902, 8140, 40912, 8147, 40918, > 8155, 40928, 8172, 40946, 8180, 40950, 8188, 8305, 8319, 41104, 8340, 8450, > 8455, 41226, 8467, 8469, 41241, 8477, 8484, 8486, 8488, 41258, 8493, 41263, > 8505, 41276, 8511, 41285, 8521, 8526, 41347, 8580, 44032, 11310, 44080, > 11358, 44128, 11372, 44148, 11383, 44160, 11492, 44288, 11557, 44336, 11621, > 11631, 44416, 11670, 44448, 11686, 44456, 11694, 44464, 11702, 44472, 11710, > 44480, 11718, 44488, 11726, 44496, 11734, 44504, 11742, 45061, 12294, 45105, > 12341, 45115, 12348, 45121, 12438, 45213, 12447, 45217, 12538, 45308, ! 12! > 543, 45317, 12588, 45361, 12686, 45472, 12727, 45552, 12799, 46080, 19893, > 52736, 32767 }; // NOLINT > +static const uint16_t kLetterTable1Size = 68; > +static const uint16_t kLetterTable1[68] = { 32768, 8123, 40960, 9356, 42775, > 10010, 43008, 10241, 43011, 10245, 43015, 10250, 43020, 10274, 43072, 10355, > 44032, 22435, 63744, 31277, 64048, 31338, 64112, 31449, 64256, 31494, 64275, > 31511, 31517, 64287, 31528, 64298, 31542, 64312, 31548, 31550, 64320, 31553, > 64323, 31556, 64326, 31665, 64467, 32061, 64848, 32143, 64914, 32199, 65008, > 32251, 65136, 32372, 65142, 32508, 65313, 32570, 65345, 32602, 65382, 32702, > 65474, 32711, 65482, 32719, 65490, 32727, 65498, 32732 }; // NOLINT > static const uint16_t kLetterTable2Size = 48; > static const uint16_t kLetterTable2[48] = { 32768, 11, 32781, 38, 32808, 58, > 32828, 61, 32831, 77, 32848, 93, 32896, 250, 33536, 798, 33584, 832, 33602, > 841, 33664, 925, 33696, 963, 33736, 975, 33792, 1181, 34816, 2053, 2056, > 34826, 2101, 34871, 2104, 2108, 2111, 35072, 2325, 2560, 35344, 2579, 35349, > 2583, 35353, 2611, 40960, 9070 }; // NOLINT > static const uint16_t kLetterTable3Size = 57; > static const uint16_t kLetterTable3[57] = { 54272, 21588, 54358, 21660, > 54430, 21663, 21666, 54437, 21670, 54441, 21676, 54446, 21689, 21691, 54461, > 21699, 54469, 21765, 54535, 21770, 54541, 21780, 54550, 21788, 54558, 21817, > 54587, 21822, 54592, 21828, 21830, 54602, 21840, 54610, 22181, 54952, 22208, > 54978, 22234, 55004, 22266, 55036, 22292, 55062, 22324, 55094, 22350, 55120, > 22382, 55152, 22408, 55178, 22440, 55210, 22466, 55236, 22475 }; // NOLINT > -static const uint16_t kLetterTable4Size = 1; > -static const uint16_t kLetterTable4[1] = { 0 }; // NOLINT > -static const uint16_t kLetterTable5Size = 3; > -static const uint16_t kLetterTable5[3] = { 9942, 63488, 31261 }; // NOLINT > +static const uint16_t kLetterTable4Size = 2; > +static const uint16_t kLetterTable4[2] = { 32768, 32767 }; // NOLINT > +static const uint16_t kLetterTable5Size = 4; > +static const uint16_t kLetterTable5[4] = { 32768, 9942, 63488, 31261 }; // > NOLINT > bool Letter::Is(uchar c) { > int chunk_index = c >> 15; > switch (chunk_index) { > @@ -505,14 +505,14 @@ bool DecimalDigit::Is(uchar c) { > > // Ideographic: 'Id' in point.properties > > -static const uint16_t kIdeographicTable0Size = 9; > -static const uint16_t kIdeographicTable0[9] = { 45062, 12295, 45089, 12329, > 45112, 12346, 13312, 19893, 19968 }; // NOLINT > -static const uint16_t kIdeographicTable1Size = 5; > -static const uint16_t kIdeographicTable1[5] = { 8123, 63744, 31277, 64112, > 31449 }; // NOLINT > -static const uint16_t kIdeographicTable4Size = 1; > -static const uint16_t kIdeographicTable4[1] = { 0 }; // NOLINT > -static const uint16_t kIdeographicTable5Size = 3; > -static const uint16_t kIdeographicTable5[3] = { 9942, 63488, 31261 }; // > NOLINT > +static const uint16_t kIdeographicTable0Size = 10; > +static const uint16_t kIdeographicTable0[10] = { 45062, 12295, 45089, 12329, > 45112, 12346, 46080, 19893, 52736, 32767 }; // NOLINT > +static const uint16_t kIdeographicTable1Size = 6; > +static const uint16_t kIdeographicTable1[6] = { 32768, 8123, 63744, 31277, > 64112, 31449 }; // NOLINT > +static const uint16_t kIdeographicTable4Size = 2; > +static const uint16_t kIdeographicTable4[2] = { 32768, 32767 }; // NOLINT > +static const uint16_t kIdeographicTable5Size = 4; > +static const uint16_t kIdeographicTable5[4] = { 32768, 9942, 63488, 31261 }; > // NOLINT > bool Ideographic::Is(uchar c) { > int chunk_index = c >> 15; > switch (chunk_index) { > Index: src/unicode.h > =================================================================== > --- src/unicode.h (^/branches/bleeding_edge/src/[EMAIL PROTECTED]) > +++ src/unicode.h (^/changes/[EMAIL > PROTECTED]/asian-letters/bleeding_edge/src/[EMAIL PROTECTED]) > @@ -1,4 +1,4 @@ > -// Copyright 2007-2008 Google Inc. All Rights Reserved. > +// Copyright 2007-2008 the V8 authors. All rights reserved. > // Redistribution and use in source and binary forms, with or without > // modification, are permitted provided that the following conditions are > // met: > Index: test/mjsunit/bugs/bug-1346700.js (deleted) > =================================================================== > Index: test/mjsunit/regress/regress-1346700.js > =================================================================== > > Property changes on: test/mjsunit/regress/regress-1346700.js > ___________________________________________________________________ > Added: svn:mergeinfo > + > >
-- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
