LGTM On Mon, Sep 8, 2008 at 2:26 PM, <[EMAIL PROTECTED]> wrote: > Mads, > > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL > PROTECTED] > > Alternatively, to review the latest snapshot of this change > branch, run > > gvn --project https://v8.googlecode.com/svn review [EMAIL > PROTECTED]/update-mozilla-status > > to review the following change: > > [EMAIL PROTECTED]/[EMAIL PROTECTED] | [EMAIL PROTECTED] | 2008-09-08 13:26:39 > +-100 (Mon, 08 Sep 2008) > > Description: > > Add two more Mozilla tests that depend on GC timings to the list > of flaky tests. > > > > Affected Paths: > M //branches/bleeding_edge/test/mozilla/mozilla.status > > > This is a semiautomated message from "gvn mail". See > <http://code.google.com/p/gvn/> to learn more. > > Index: test/mozilla/mozilla.status > =================================================================== > --- test/mozilla/mozilla.status (^/branches/bleeding_edge/test/mozilla/[EMAIL > PROTECTED]) > +++ test/mozilla/mozilla.status (^/changes/[EMAIL > PROTECTED]/update-mozilla-status/bleeding_edge/test/mozilla/[EMAIL PROTECTED]) > @@ -165,8 +165,10 @@ js1_5/Regress/regress-98901: PASS || FAIL > js1_5/extensions/regress-371636: PASS || FAIL > > > -# Test depends on GC timings. Inherently flaky. > +# Tests depend on GC timings. Inherently flaky. > js1_5/GC/regress-383269-01: PASS || FAIL > +js1_5/GC/regress-383269-02: PASS || FAIL > +js1_5/Regress/regress-404755.js: PASS || FAIL > > > ##################### INCOMPATIBLE TESTS ##################### > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
