LGTM. On Mon, Sep 8, 2008 at 2:39 PM, <[EMAIL PROTECTED]> wrote: > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL > PROTECTED] > > Alternatively, to review the latest snapshot of this change > branch, run > > gvn --project https://v8.googlecode.com/svn review [EMAIL > PROTECTED]/sourcesignatures > > to review the following change: > > [EMAIL PROTECTED]/[EMAIL PROTECTED] | [EMAIL PROTECTED] | 2008-09-08 13:38:53 > +-100 (Mon, 08 Sep 2008) > > Description: > > - Added option to set SourceSignatures in scons. > > > > > Affected Paths: > M //branches/bleeding_edge/SConstruct > > > This is a semiautomated message from "gvn mail". See > <http://code.google.com/p/gvn/> to learn more. > > Index: SConstruct > =================================================================== > --- SConstruct (^/branches/bleeding_edge/[EMAIL PROTECTED]) > +++ SConstruct (^/changes/[EMAIL > PROTECTED]/sourcesignatures/bleeding_edge/[EMAIL PROTECTED]) > @@ -294,6 +294,11 @@ SIMPLE_OPTIONS = { > 'values': ['on', 'off'], > 'default': 'off', > 'help': 'enable the disassembler to inspect generated code' > + }, > + 'sourcesignatures': { > + 'values': ['MD5', 'timestamp'], > + 'default': 'MD5', > + 'help': 'set how the build system detects file changes' > } > } > > @@ -492,6 +497,8 @@ def Build(): > VerifyOptions(env) > env_overrides = ParseEnvOverrides(env['env']) > > + SourceSignatures(env['sourcesignatures']) > + > libraries = [] > cctests = [] > samples = [] > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
