Issue 47: cpplint.py missing from repository?
http://code.google.com/p/v8/issues/detail?id=47

New issue report by mdmkolbe:
The guide on contributing (http://code.google.com/p/v8/wiki/Contributing)
says that one should run tools/presubmit.py before submitting.  However,
tools/presubmit.py tries to call a script named "cpplint.py".  This script
is not in the repository and I have not been able to find any third party
project that includes such a tool.  Of course, this check can be bypassed
with "--no-lint", but that kind of defeats the purpose of having
tools/presubmit.py since it appears cpplint.py does the bulk of the work in
tools/presubmit.py.

Either,
  (1) the wiki should point to where to get cpplint.py (if cpplint.py is
part of a separate or third party project), or
  (2) cpplint.py should be included in the repository (if cpplint.py is from
google and can be released), or
  (3) the wiki should be updated to note that outside contributors will need
to pass the "--no-lint" option since cpplint.py will not exist on their
system (if cpplint.py is internal to google and cannot be released).



Issue attributes:
        Status: New
        Owner: ----

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to