Was ApplyEnvOverrides defined already? Lgtm.
On Mon, Sep 8, 2008 at 5:20 PM, Søren Gjesse <[EMAIL PROTECTED]> wrote: > New snapshot with > - sample_env['ENV'].update(**context.env_overrides) > + context.ApplyEnvOverrides(sample_env) > instead of > - sample_env['ENV'].update(**context.env_overrides) > + context.ApplyEnvOverrides(env) > On Mon, Sep 8, 2008 at 5:16 PM, <[EMAIL PROTECTED]> wrote: >> >> I'd like you to do a code review. To review this change, run >> >> gvn review --project https://v8.googlecode.com/svn/branches/bleeding_edge >> sgjesse/[EMAIL PROTECTED] >> >> Alternatively, to review the latest snapshot of this change >> branch, run >> >> gvn --project https://v8.googlecode.com/svn/branches/bleeding_edge review >> sgjesse/fix-env-overrides >> >> to review the following change: >> >> *sgjesse/[EMAIL PROTECTED] | sgjesse | 2008-09-08 15:27:19 +-100 (Mon, >> 08 Sep 2008) >> >> Description: >> >> Added ApplyEnvOverrides to samples build. This makes the build work on >> Windows >> when the PATH to cl.exe is specified through env overrides. Changed >> explicit >> EVN update with call to ApplyEnvOverrides >> >> >> >> Affected Paths: >> M //branches/bleeding_edge/SConstruct >> M //branches/bleeding_edge/samples/SConscript >> >> >> This is a semiautomated message from "gvn mail". See >> <http://code.google.com/p/gvn/> to learn more. >> >> Index: SConstruct >> =================================================================== >> --- SConstruct (^/branches/bleeding_edge/[EMAIL PROTECTED]) >> +++ SConstruct >> (^/changes/sgjesse/fix-env-overrides/bleeding_edge/[EMAIL PROTECTED]) >> @@ -467,7 +467,7 @@ def BuildSpecific(env, mode, env_overrides): >> for sample in context.samples: >> sample_env = Environment(LIBRARY=library_name) >> sample_env.Replace(**context.flags['sample']) >> - sample_env['ENV'].update(**context.env_overrides) >> + context.ApplyEnvOverrides(env) >> sample_object = sample_env.SConscript( >> join('samples', 'SConscript'), >> build_dir=join('obj', 'sample', sample, target_id), >> Index: samples/SConscript >> =================================================================== >> --- samples/SConscript (^/branches/bleeding_edge/samples/[EMAIL PROTECTED]) >> +++ samples/SConscript >> (^/changes/sgjesse/fix-env-overrides/bleeding_edge/samples/[EMAIL >> PROTECTED]) >> @@ -31,6 +31,7 @@ Import('sample context') >> def ConfigureObjectFiles(): >> env = Environment() >> env.Replace(**context.flags['sample']) >> + context.ApplyEnvOverrides(env) >> return env.Object(sample + '.cc') >> >> sample_object = ConfigureObjectFiles() >> >> >> >> > > > > -- > Søren Gjesse > H.C. Ørsteds Vej 1 A > Tlf:. 86 14 75 35 > Mobil: 22 77 84 51 > e-mail: [EMAIL PROTECTED] (personlig) > e-mail: [EMAIL PROTECTED] (familie) > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
