http://codereview.chromium.org/1604/diff/203/17 File src/ic.cc (right):
http://codereview.chromium.org/1604/diff/203/17#newcode293 Line 293: if (result->IsJSFunction()) return result; It will fail in lookup step, a comment is sufficient, I think, instead of duplicating code here. On 2008/09/08 05:27:21, Kasper Lund wrote: > Do you really want to continue with a doing a normal lookup here? Isn't that > going to fail all the time? If that's the case at least it should be documented > in a comment here. http://codereview.chromium.org/1604/diff/203/17#newcode365 Line 365: result : TypeError("property_not_function", object, name); On 2008/09/08 05:27:21, Kasper Lund wrote: > Isn't this usually indented with 4 spaces? I can't remember. Done. http://codereview.chromium.org/1604/diff/203/16 File test/mjsunit/number-string-index-call.js (right): http://codereview.chromium.org/1604/diff/203/16#newcode5 Line 5: // The following test only works when --call_regexp is enabled in V8. On 2008/09/08 05:27:21, Kasper Lund wrote: > You can enable flags for specific test by adding a comment like this: > // Flags: --call-regexp > to this test file. We shouldn't have comments with code in them in our tests. Done. http://codereview.chromium.org/1604 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
