http://codereview.chromium.org/457/diff/1/8 File src/heap.h (right):
http://codereview.chromium.org/457/diff/1/8#newcode538 Line 538: // EvalCache caches function boilerplates for compiled scripts On 2008/09/05 09:16:29, Kasper Lund wrote: > I would move this code out into a separate class with static operations; > something like CompilationCache maybe? Let's do that in our next step. Also I'd like to see the cache performance for whole compilation. Another thing is that we might be able to use 1 element cache since the cached function has source code already. Also we may want to cache shared function info instead of the function. http://codereview.chromium.org/457/diff/1/8#newcode544 Line 544: // Caches are cleared before mark-compact GC's. On 2008/09/05 09:16:29, Kasper Lund wrote: > Isn't this really for all mark-sweep GCs - not just the compacting ones? Both, but since we use the same name Heap::MarkCompact. I probably should say 'global GC'. http://codereview.chromium.org/457/diff/1/8#newcode557 Line 557: static Object* PutInEvalCache(bool is_global_context, On 2008/09/05 09:16:29, Kasper Lund wrote: > Indentation of the arguments should align them below each other. Done. http://codereview.chromium.org/457/diff/1/5 File src/objects.h (right): http://codereview.chromium.org/457/diff/1/5#newcode1821 Line 1821: // EvalCache for caching eval'ed string and function. On 2008/09/05 09:16:29, Kasper Lund wrote: > Rename to CompilationCacheTable? Done. http://codereview.chromium.org/457/diff/1/4 File src/runtime.cc (right): http://codereview.chromium.org/457/diff/1/4#newcode3331 Line 3331: bool is_global_context = context->IsGlobalContext(); On 2008/09/05 09:16:29, Kasper Lund wrote: > I think you should move this code to the Compiler and use it for scripts too. It > would be nice to be able to just put it in compiler.cc:MakeFunction but that may > be a little to late because the Compile, CompileLazy, CompileEval functions > build script data structures and may do pre-parsing which should be avoided too. > You probably have to refactor it a bit. Done. http://codereview.chromium.org/457 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
