Reviewers: christian.plesner.hansen, Description: Use RUNTIME_ASSERT instead of CHECK in runtime.cc.
Remove unused function from array.js. Please review this at http://codereview.chromium.org/1659 Affected files: M src/array.js M src/runtime.cc Index: src/runtime.cc =================================================================== --- src/runtime.cc (revision 228) +++ src/runtime.cc (working copy) @@ -3450,7 +3450,7 @@ ASSERT(args.length() == 2); CONVERT_CHECKED(JSArray, array, args[0]); CONVERT_CHECKED(JSArray, element, args[1]); - CHECK(array->HasFastElements()); + RUNTIME_ASSERT(array->HasFastElements()); int length = Smi::cast(array->length())->value(); FixedArray* elements = FixedArray::cast(array->elements()); for (int i = 0; i < length; i++) { Index: src/array.js =================================================================== --- src/array.js (revision 224) +++ src/array.js (working copy) @@ -31,16 +31,7 @@ // ------------------------------------------------------------------- -// Determines if the array contains the element. -function Contains(array, element) { - var length = array.length; - for (var i = 0; i < length; i++) { - if (array[i] === element) return true; - } - return false; -}; - // Global list of arrays visited during toString, toLocaleString and // join invocations. var visited_arrays = new $Array(); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
