I'd like you to do a code review. To review this change, run gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL PROTECTED]
Alternatively, to review the latest snapshot of this change branch, run gvn --project https://v8.googlecode.com/svn review [EMAIL PROTECTED]/fix-stack-overflow-crash to review the following change: [EMAIL PROTECTED]/[EMAIL PROTECTED] | [EMAIL PROTECTED] | 2008-09-10 14:56:18 +-100 (Wed, 10 Sep 2008) Description: Fixed stack overflow crash. Affected Paths: M //branches/bleeding_edge/src/top.cc This is a semiautomated message from "gvn mail". See <http://code.google.com/p/gvn/> to learn more. Index: src/top.cc =================================================================== --- src/top.cc (^/branches/bleeding_edge/src/[EMAIL PROTECTED]) +++ src/top.cc (^/changes/[EMAIL PROTECTED]/fix-stack-overflow-crash/bleeding_edge/src/[EMAIL PROTECTED]) @@ -770,7 +770,7 @@ void Top::DoThrow(Object* exception, Handle<Object> message_obj; MessageLocation potential_computed_location; - if (is_caught_externally || report_exception) { + if (report_exception) { if (location == NULL) { // If no location was specified we use a computed one instead ComputeLocation(&potential_computed_location); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
