LGTM On Thu, Sep 11, 2008 at 9:04 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: erik.corry, > > Description: > Remove a test from threading tests that make them fail on Mac OS. > > Please review this at http://codereview.chromium.org/2415 > > Affected files: > M test/cctest/test-api.cc > > > Index: test/cctest/test-api.cc > =================================================================== > --- test/cctest/test-api.cc (revision 259) > +++ test/cctest/test-api.cc (working copy) > @@ -4845,7 +4845,9 @@ > } > > > -THREADED_TEST(CatchStackOverflow) { > +// If part of the threaded tests, this test makes ThreadingTest fail > +// on mac. > +TEST(CatchStackOverflow) { > v8::HandleScope scope; > LocalContext context; > v8::TryCatch try_catch; > > >
-- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
