LGTM On Thu, Sep 11, 2008 at 9:24 AM, <[EMAIL PROTECTED]> wrote: > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL > PROTECTED] > > Alternatively, to review the latest snapshot of this change > branch, run > > gvn --project https://v8.googlecode.com/svn review [EMAIL > PROTECTED]/remove-stack-trace > > to review the following change: > > [EMAIL PROTECTED]/[EMAIL PROTECTED] | [EMAIL PROTECTED] | 2008-09-11 08:23:32 > +-100 (Thu, 11 Sep 2008) > > Description: > > Removed Message::GetStackTrace. > > > > > Affected Paths: > M //branches/bleeding_edge/include/v8.h > M //branches/bleeding_edge/samples/shell.cc > M //branches/bleeding_edge/src/api.cc > > > This is a semiautomated message from "gvn mail". See > <http://code.google.com/p/gvn/> to learn more. > > Index: include/v8.h > =================================================================== > --- include/v8.h (^/branches/bleeding_edge/include/[EMAIL PROTECTED]) > +++ include/v8.h (^/changes/[EMAIL > PROTECTED]/remove-stack-trace/bleeding_edge/include/[EMAIL PROTECTED]) > @@ -595,12 +595,6 @@ class EXPORT Message { > */ > int GetEndColumn(); > > - /** > - * Returns a string stack trace if trace_exceptions is enabled and > - * one is available. > - */ > - Local<String> GetStackTrace(); > - > // TODO(1245381): Print to a string instead of on a FILE. > static void PrintCurrentStackTrace(FILE* out); > }; > Index: samples/shell.cc > =================================================================== > --- samples/shell.cc (^/branches/bleeding_edge/samples/[EMAIL PROTECTED]) > +++ samples/shell.cc (^/changes/[EMAIL > PROTECTED]/remove-stack-trace/bleeding_edge/samples/[EMAIL PROTECTED]) > @@ -246,10 +246,5 @@ void ReportException(v8::TryCatch* try_catch) { > printf("^"); > } > printf("\n"); > - v8::Handle<v8::String> stack_trace = message->GetStackTrace(); > - if (!stack_trace.IsEmpty()) { > - v8::String::Utf8Value stack_trace_str(stack_trace); > - printf("%s\n", *stack_trace_str); > - } > } > } > Index: src/api.cc > =================================================================== > --- src/api.cc (^/branches/bleeding_edge/src/[EMAIL PROTECTED]) > +++ src/api.cc (^/changes/[EMAIL > PROTECTED]/remove-stack-trace/bleeding_edge/src/[EMAIL PROTECTED]) > @@ -1261,20 +1261,6 @@ int Message::GetEndColumn() { > } > > > -v8::Local<v8::String> Message::GetStackTrace() { > - if (IsDeadCheck("v8::Message::GetStackTrace()")) > - return v8::Local<v8::String>(); > - HandleScope scope; > - i::Handle<i::JSObject> data_obj = Utils::OpenHandle(this); > - i::Handle<i::Object> trace = GetProperty(data_obj, "stackTrace"); > - if (trace->IsString()) { > - return scope.Close(Utils::ToLocal(i::Handle<i::String>::cast(trace))); > - } else { > - return Local<String>(); > - } > -} > - > - > Local<String> Message::GetSourceLine() { > ON_BAILOUT("v8::Message::GetSourceLine()", return Local<String>()); > HandleScope scope; > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
