Reviewers: Kasper Lund, Message: I threw away all the dynamic flag stuff, it was too complicated. This means that we have a few testing flags in our v8 binaries, but we can work on removing those later.
Hope you're prepared for the review of doom. Description: This is a new static flag system, designed to have all flags in a central place, and compiled into the binary without requiring static constructors for registration. All flags are moved out of the specific modules and into flags.defs, with different sections for debug, release, etc. The flag variables are always defined. For example, a debug flag in release mode still exists, but is read only and set to the default value. Please review this at http://codereview.chromium.org/1935 Affected files: src/api.cc src/assembler-arm.cc src/assembler-ia32.cc src/ast.h src/bootstrapper.cc src/builtins-ia32.cc src/builtins.cc src/checks.cc src/checks.h src/code-stubs.cc src/codegen-arm.cc src/codegen-ia32.cc src/codegen.cc src/codegen.h src/compiler.cc src/contexts.cc src/debug.cc src/execution.cc src/flags-inl.h src/flags.cc src/flags.defs src/flags.h src/frames.cc src/handles.cc src/heap-inl.h src/heap.cc src/ic-ia32.cc src/ic.cc src/log.cc src/macro-assembler-arm.cc src/macro-assembler-ia32.cc src/mark-compact.cc src/mksnapshot.cc src/objects.cc src/parser.cc src/runtime.cc src/scopes.cc src/serialize.cc src/simulator-arm.cc src/spaces.cc src/stub-cache.cc src/top.cc src/usage-analyzer.cc src/v8.cc src/v8.h test/cctest/test-api.cc test/cctest/test-debug.cc test/cctest/test-flags.cc test/cctest/test-mark-compact.cc test/cctest/test-serialize.cc tools/v8.xcodeproj/project.pbxproj --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
