lgtm On Thu, Sep 11, 2008 at 1:57 PM, <[EMAIL PROTECTED]> wrote: > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn/branches/bleeding_edge > lrn/[EMAIL PROTECTED] > > Alternatively, to review the latest snapshot of this change > branch, run > > gvn --project https://v8.googlecode.com/svn/branches/bleeding_edge review > lrn/re_log > > to review the following change: > > *lrn/[EMAIL PROTECTED] | lrn | 2008-09-11 12:55:04 +-100 (Thu, 11 Sep 2008) > > Description: > > Fixed build error on Linux. > > > > > Affected Paths: > R //branches/bleeding_edge/src/log.h > > > This is a semiautomated message from "gvn mail". See > <http://code.google.com/p/gvn/> to learn more. > > Index: src/log.h > =================================================================== > --- src/log.h (added) > > +++ src/log.h (^/changes/lrn/re_log/bleeding_edge/src/[EMAIL PROTECTED]) > > @@ -193,7 +193,7 @@ class Logger { > > private: > > // Emits the source code of a regexp. Used by regexp events. > - static void Logger::LogRegExpSource(Handle<JSValue> regexp); > + static void LogRegExpSource(Handle<JSValue> regexp); > > // Emits a profiler tick event. Used by the profiler thread. > static void TickEvent(TickSample* sample, bool overflow); > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
