I'd like you to do a code review. To review this change, run gvn review --project https://v8.googlecode.com/svn/branches/bleeding_edge lrn/[EMAIL PROTECTED]
Alternatively, to review the latest snapshot of this change branch, run gvn --project https://v8.googlecode.com/svn/branches/bleeding_edge review lrn/presubmit_fix to review the following change: *lrn/[EMAIL PROTECTED] | lrn | 2008-09-11 13:25:09 +-100 (Thu, 11 Sep 2008) Description: Formatting fixes (e.g., whitespace at end of line) Added in-file documentation for --log-regexp switch. Affected Paths: R //branches/bleeding_edge/src/log.cc R //branches/bleeding_edge/src/log.h R //branches/bleeding_edge/src/objects.h R //branches/bleeding_edge/src/smart-pointer.h This is a semiautomated message from "gvn mail". See <http://code.google.com/p/gvn/> to learn more. Index: src/log.cc =================================================================== --- src/log.cc (added) +++ src/log.cc (^/changes/lrn/presubmit_fix/bleeding_edge/src/[EMAIL PROTECTED]) @@ -371,7 +371,7 @@ void Logger::SharedLibraryEvent(const wchar_t* lib } void Logger::LogRegExpSource(Handle<JSValue> regexp) { - // Prints "/" + re.source + "/" + + // Prints "/" + re.source + "/" + // (re.global?"g":"") + (re.ignorecase?"i":"") + (re.multiline?"m":"") Handle<Object> source = GetProperty(regexp, "source"); @@ -427,14 +427,15 @@ void Logger::RegExpCompileEvent(Handle<JSValue> re void Logger::RegExpExecEvent(Handle<JSValue> regexp, int start_index, - Handle<String> string) { + Handle<String> input_string) { #ifdef ENABLE_LOGGING_AND_PROFILING if (logfile_ == NULL || !FLAG_log_regexp) return; ScopedLock sl(mutex_); fprintf(logfile_, "regexp-run,"); LogRegExpSource(regexp); - fprintf(logfile_, ",0x%08x,%d..%d\n", string->Hash(), start_index, string->length()); + fprintf(logfile_, ",0x%08x,%d..%d\n", + input_string->Hash(), start_index, input_string->length()); #endif } Index: src/log.h =================================================================== --- src/log.h (added) +++ src/log.h (^/changes/lrn/presubmit_fix/bleeding_edge/src/[EMAIL PROTECTED]) @@ -40,7 +40,7 @@ namespace v8 { namespace internal { // // --log-all // Log all events to the file, default is off. This is the same as combining -// --log-api, --log-code, and --log-gc. +// --log-api, --log-code, --log-gc, and --log-regexp. // // --log-api // Log API events to the logfile, default is off. --log-api implies --log. @@ -53,6 +53,10 @@ namespace v8 { namespace internal { // Log GC heap samples after each GC that can be processed by hp2ps, default // is off. --log-gc implies --log. // +// --log-regexp +// Log creation and use of regular expressions, Default is off. +// --log-regexp implies --log. +// // --logfile <filename> // Specify the name of the logfile, default is "v8.log". // @@ -179,9 +183,9 @@ class Logger { static void RegExpCompileEvent(Handle<JSValue> regexp); - static void RegExpExecEvent(Handle<JSValue> regexp, - int start_index, - Handle<String> string); + static void RegExpExecEvent(Handle<JSValue> regexp, + int start_index, + Handle<String> input_string); #ifdef ENABLE_LOGGING_AND_PROFILING static StateTag state() { Index: src/objects.h =================================================================== --- src/objects.h (added) +++ src/objects.h (^/changes/lrn/presubmit_fix/bleeding_edge/src/[EMAIL PROTECTED]) @@ -2861,7 +2861,8 @@ class String: public HeapObject { // ROBUST_STRING_TRAVERSAL invokes behaviour that is robust This means it // handles unexpected data without causing assert failures and it does not // do any heap allocations. This is useful when printing stack traces. - SmartPointer<uc16> ToWideCString(RobustnessFlag robustness_flag = FAST_STRING_TRAVERSAL); + SmartPointer<uc16> ToWideCString( + RobustnessFlag robustness_flag = FAST_STRING_TRAVERSAL); // Tells whether the hash code has been computed. inline bool HasHashCode(); Index: src/smart-pointer.h =================================================================== --- src/smart-pointer.h (added) +++ src/smart-pointer.h (^/changes/lrn/presubmit_fix/bleeding_edge/src/[EMAIL PROTECTED]) @@ -37,7 +37,7 @@ template<typename T> class SmartPointer { public: - // Default constructor. Construct an empty scoped pointer. + // Default constructor. Construct an empty scoped pointer. inline SmartPointer() : p(NULL) {} @@ -86,8 +86,8 @@ class SmartPointer { // the copy constructor it removes the pointer in the original to avoid // double freeing. inline SmartPointer& operator=(const SmartPointer<T>& rhs) { - ASSERT(p == NULL); - T* tmp = rhs.p; // swap to handle self-assignment + ASSERT(p == NULL); + T* tmp = rhs.p; // swap to handle self-assignment const_cast<SmartPointer<T>&>(rhs).p = NULL; p = tmp; return *this; --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
