Hi Dean Great first step to move all flags to one file. However, it would be perfect if you could eliminate the flags.defs.
Otherwise, LGTM, Lars http://codereview.chromium.org/1935/diff/53/271 File src/flags.defs (right): http://codereview.chromium.org/1935/diff/53/271#newcode1 Line 1: // Copyright 2008 the V8 project authors. All rights reserved. I understand the reason for the state based include but we should reduce flags to be in release or in release+debug. Since most flags is compiled away in release mode, I think this is OK. If you make this change flags can be defined in ONE giant macro. This will also eliminate the need for flags.def. http://codereview.chromium.org/1935/diff/53/272 File src/flags.h (right): http://codereview.chromium.org/1935/diff/53/272#newcode35 Line 35: #define FLAG_MODE_DECLARE I don't like the defs file extension. Please use .h as extension. After all, it is a C++ header file. http://codereview.chromium.org/1935 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
