Author: [EMAIL PROTECTED]
Date: Thu Sep 11 07:39:11 2008
New Revision: 284
Modified:
branches/bleeding_edge/SConstruct
Log:
Apply the flags to the SCons environment used to link the library to have
the
LINKFLAGS take effect. This fixes building shared libraries on 64-bit Linux.
Removed the CCFLAGS from the CXXFLAGS for Linux as SCons combines these
automatically on Linux. This removed the duplication of flags when
compiling on
Linux.
On Linux SCons defines CXXCOM as follows
'CXXCOM': '$CXX -o $TARGET -c $CXXFLAGS $CCFLAGS $_CCCOMCOM $SOURCES'
whereas on Windows it is
'CXXCOM': '$CXX $CXXFLAGS $CCCOMFLAGS'
Review URL: http://codereview.chromium.org/2422
Modified: branches/bleeding_edge/SConstruct
==============================================================================
--- branches/bleeding_edge/SConstruct (original)
+++ branches/bleeding_edge/SConstruct Thu Sep 11 07:39:11 2008
@@ -45,7 +45,7 @@
'DIALECTFLAGS': ['-ansi'],
'CCFLAGS': ['$DIALECTFLAGS', '$WARNINGFLAGS',
'-fno-strict-aliasing'],
- 'CXXFLAGS': ['$CCFLAGS', '-fno-rtti', '-fno-exceptions'],
+ 'CXXFLAGS': ['-fno-rtti', '-fno-exceptions'],
'LIBS': ['pthread']
},
'mode:debug': {
@@ -454,6 +454,7 @@
)
# Link the object files into a library.
+ env.Replace(**context.flags['v8'])
context.ApplyEnvOverrides(env)
if context.options['library'] == 'static':
library = env.StaticLibrary(library_name, object_files)
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
