Lgtm On Thu, Sep 11, 2008 at 5:15 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: christian.plesner.hansen, > > Description: > Removed SCons warning flags duplication on Windows. It now uses > the same scheme as for gcc on Linux. > > Please review this at http://codereview.chromium.org/2424 > > Affected files: > M SConstruct > > > Index: SConstruct > =================================================================== > --- SConstruct (revision 284) > +++ SConstruct (working copy) > @@ -63,7 +63,6 @@ > 'msvc': { > 'all': { > 'DIALECTFLAGS': ['/nologo'], > - 'WARNINGFLAGS': ['/W3', '/WX', '/wd4355', '/wd4800'], > 'CCFLAGS': ['$DIALECTFLAGS', '$WARNINGFLAGS'], > 'CXXFLAGS': ['$CCFLAGS', '/GR-', '/Gy'], > 'CPPDEFINES': ['WIN32', '_USE_32BIT_TIME_T', 'PCRE_STATIC'], > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
