D'oh, you're right. It was late in a busy day is all I can say. I'll clean it up in the next change.
On Thu, Sep 11, 2008 at 8:25 PM, <[EMAIL PROTECTED]> wrote: > I know this has been committed... > > -Ivan > > > > > http://codereview.chromium.org/2002/diff/1/2 > File src/codegen-arm.cc (right): > > http://codereview.chromium.org/2002/diff/1/2#newcode988 > Line 988: if (skipped_write) masm->bind(&exit); > Why do you introduce a separate variable for testing (init_state == > CONST_INIT)? In my opinion that is more confusing. Same for ia32. > > > http://codereview.chromium.org/2002 > -- Google Denmark ApS CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
