LGTM. On Thu, Sep 11, 2008 at 7:57 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Message: > I forgot to try cross-compiling for ARM in debug mode as well. D'oh. > > The 64-bit linux issues are actually unrelated -- they are caused by > Søren's changes to the build system. > > > > Description: > Fixed some arm debug issues I had missed the first time round. > > > Please review this at http://codereview.chromium.org/1944 > > Affected files: > M src/disasm-arm.cc > > > Index: src/disasm-arm.cc > =================================================================== > --- src/disasm-arm.cc (revision 287) > +++ src/disasm-arm.cc (working copy) > @@ -56,7 +56,6 @@ > : converter_(converter), > out_buffer_(out_buffer), > out_buffer_pos_(0) { > - ASSERT(out_buffer_size_ > 0); > out_buffer_[out_buffer_pos_] = '\0'; > } > > @@ -96,7 +95,6 @@ > > // Append the ch to the output buffer. > void Decoder::PrintChar(const char ch) { > - ASSERT(out_buffer_pos_ < out_buffer_size_); > out_buffer_[out_buffer_pos_++] = ch; > } > > @@ -430,7 +428,6 @@ > } > cur = *format++; > } > - ASSERT(out_buffer_pos_ < out_buffer_size_); > out_buffer_[out_buffer_pos_] = '\0'; > } > > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
