Reviewers: Kasper Lund,
Description:
- Update test status file with fixed tests for ARM and add failing test
tracked by issue 67.
- Remove debugging aid stop("Generate_ArgumentsAdaptorTrampoline -
non-function call")
- Cleanup comment
Please review this at http://codereview.chromium.org/2801
Affected files:
M src/builtins-arm.cc
M src/top.cc
M test/mjsunit/mjsunit.status
Index: test/mjsunit/mjsunit.status
===================================================================
--- test/mjsunit/mjsunit.status (revision 288)
+++ test/mjsunit/mjsunit.status (working copy)
@@ -62,6 +62,6 @@
debug-stepin-constructor: FAIL
debug-step: FAIL
regress/regress-998565: FAIL
-regress/regress-1081309: FAIL
-# Call as function does not always work on ARM port yet.
-number-string-index-call: FAIL
+
+# Issue 67: ARM fails in: Generate_ArgumentsAdaptorTrampoline -
non-function call
+call-non-function-call: FAIL
Index: src/top.cc
===================================================================
--- src/top.cc (revision 288)
+++ src/top.cc (working copy)
@@ -621,9 +621,6 @@
}
-// TODO(1233523): Get rid of this hackish abstraction once all
-// JavaScript frames have a function associated with them.
-
// NOTE: The stack trace frame iterator is an iterator that only
// traverse proper JavaScript frames; that is JavaScript frames that
// have proper JavaScript functions. This excludes the problematic
Index: src/builtins-arm.cc
===================================================================
--- src/builtins-arm.cc (revision 289)
+++ src/builtins-arm.cc (working copy)
@@ -644,7 +644,7 @@
{ Label invoke;
__ tst(r1, r1);
__ b(ne, &invoke);
- __ stop("Generate_ArgumentsAdaptorTrampoline - non-function call");
+ //__ stop("Generate_ArgumentsAdaptorTrampoline - non-function call");
__ mov(r2, Operand(0)); // expected arguments is 0 for
CALL_NON_FUNCTION
__ GetBuiltinEntry(r3, Builtins::CALL_NON_FUNCTION);
__ b(&enough);
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
