LGTM, Lars
http://codereview.chromium.org/2957/diff/1/7 File src/assembler-arm.h (right): http://codereview.chromium.org/2957/diff/1/7#newcode647 Line 647: int last_position() const { return last_position_; } It might be a good idea to introduce a class capturing (position and is_statement). http://codereview.chromium.org/2957/diff/1/8 File src/assembler-ia32.cc (right): http://codereview.chromium.org/2957/diff/1/8#newcode1883 Line 1883: if (last_position_ != kNoPosition && Add () in expression. http://codereview.chromium.org/2957/diff/1/6 File src/debug.cc (right): http://codereview.chromium.org/2957/diff/1/6#newcode98 Line 98: // passed. Please update the comment to reflect when position_ is updated. http://codereview.chromium.org/2957/diff/1/3 File src/objects.cc (right): http://codereview.chromium.org/2957/diff/1/3#newcode4150 Line 4150: // Update the position if Please update and reformat the comment. http://codereview.chromium.org/2957/diff/1/3#newcode4157 Line 4157: (pc - it.rinfo()->pc()) < distance || Add parenthesis to reflect the grouping in boolean expression. http://codereview.chromium.org/2957 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
