Right - switched .cc and .h. The Visual Studio UI sorts the files independent of the order in the .vcproj file anyway though. /Søren
On Fri, Sep 19, 2008 at 10:42 AM, Kasper Lund <[EMAIL PROTECTED]> wrote: > > Usually the .h files come after the .cc files in the list, but other > than that it LGTM. > > On Fri, Sep 19, 2008 at 10:06 AM, <[EMAIL PROTECTED]> wrote: > > > > Reviewers: christian.plesner.hansen, > > > > Description: > > Add assembler.h the the Visual Studio project file. > > > > Please review this at http://codereview.chromium.org/2985 > > > > Affected files: > > M tools/visual_studio/v8_base.vcproj > > > > > > Index: tools/visual_studio/v8_base.vcproj > > =================================================================== > > --- tools/visual_studio/v8_base.vcproj (revision 344) > > +++ tools/visual_studio/v8_base.vcproj (working copy) > > @@ -305,6 +305,10 @@ > > > > > </File> > > <File > > + RelativePath="..\..\src\assembler.h" > > + > > > + </File> > > + <File > > RelativePath="..\..\src\assembler.cc" > > > > > </File> > > > > > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
