LGTM
http://codereview.chromium.org/2989/diff/4/204 File src/runtime.cc (right): http://codereview.chromium.org/2989/diff/4/204#newcode938 Line 938: // the overhead of setting up KMP. TODO get more accurate cutoffs here. Either leave out the TODO or report a bug and use the bug ID here: TODO(bugid): get more... http://codereview.chromium.org/2989/diff/4/204#newcode941 Line 941: // the common case of the first character not matching is fast. the the -> that the http://codereview.chromium.org/2989/diff/4/204#newcode946 Line 946: for (int j = 1; j < pattern_length; ++j) { I think we use j++ consistently in the rest of the code. At least this should be consistent with the outer for loop. http://codereview.chromium.org/2989 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
