http://codereview.chromium.org/3181/diff/1/2 File src/runtime.cc (left):
http://codereview.chromium.org/3181/diff/1/2#oldcode921 Line 921: if (!Array::IndexFromObject(index, &start_index)) return Smi::FromInt(-1); As you pointed out in mail we have to have this check in the C code. I wonder whether you could put it back in without losing performance. It could be that the performance gain you are seeing just comes from not doing the rather slow runtime call in the pattern_length==0 case? Apart from this LGTM http://codereview.chromium.org/3181 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
