Should we use the same flag in the SConstruct build? On Sun, Sep 21, 2008 at 3:50 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: M-A, Søren Gjesse, > > Message: > Apparently /GF doesn't come with /Ox (although it comes with /O1 and > /02?). > > 1211392 Sep 21 14:39 /tmp/e/rel/v8_shell_sample.exe > 1165824 Sep 21 15:42 /tmp/e/spool/v8_shell_sample.exe > > > Description: > Enable string pooling in the VS release build. This saves 46k for a > v8_shell_sample.exe, I didn't measure performance or the overall change > to a Chromium build. I think this option should always make sense > anyway, unless we're using some string constants incorrectly. > > Please review this at http://codereview.chromium.org/3182 > > Affected files: > M tools/visual_studio/release.vsprops > > > Index: tools/visual_studio/release.vsprops > diff --git a/tools/visual_studio/release.vsprops > b/tools/visual_studio/release.vsprops > index > 311e7cf69bd61160e32da7796749b6fee8ed7b71..41b1ccd5254e6572d7395dbc64d606da226194e5 > 100644 > --- a/tools/visual_studio/release.vsprops > +++ b/tools/visual_studio/release.vsprops > @@ -12,6 +12,7 @@ > EnableIntrinsicFunctions="true" > FavorSizeOrSpeed="0" > OmitFramePointers="true" > + StringPooling="true" > /> > <Tool > Name="VCLinkerTool" > > > > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
