Thanks for the feedback Ivan. I'll document the register contract in the interface for the Enter/Leave functions on both platforms.
On Tue, Sep 23, 2008 at 9:51 AM, <[EMAIL PROTECTED]> wrote: > > http://codereview.chromium.org/4035/diff/1/10 > File src/codegen-arm.cc (right): > > http://codereview.chromium.org/4035/diff/1/10#newcode1645 > Line 1645: __ mov(r1, Operand(r6)); > Please add r6 to the contract with calling code above. > > http://codereview.chromium.org/4035/diff/1/12 > File src/codegen-ia32.cc (right): > > http://codereview.chromium.org/4035/diff/1/12#newcode5262 > Line 5262: __ mov(Operand(esp, 1 * kPointerSize), esi); // argv. > Please add the definition of esi to the contract above. > > http://codereview.chromium.org/4035 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
