Lgtm! On Wed, Sep 24, 2008 at 10:32 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: christian.plesner.hansen, > > Description: > Added a profiling option (prof) to the SCons build. Currently > it just makes the linker generate a MAP file for the shell > sample on Windows. > > Please review this at http://codereview.chromium.org/4064 > > Affected files: > M SConstruct > > > Index: SConstruct > =================================================================== > --- SConstruct (revision 366) > +++ SConstruct (working copy) > @@ -201,6 +201,9 @@ > 'library:shared': { > 'CPPDEFINES': ['USING_V8_SHARED'] > }, > + 'prof:on': { > + 'LINKFLAGS': ['/MAP'] > + }, > 'mode:release': { > 'CCFLAGS': ['/Ox', '/MT', '/GF'], > 'LINKFLAGS': ['/OPT:REF', '/OPT:ICF'] > @@ -280,6 +283,11 @@ > 'default': 'off', > 'help': 'build using snapshots for faster start-up' > }, > + 'prof': { > + 'values': ['on', 'off'], > + 'default': 'off', > + 'help': 'enable profiling of build target' > + }, > 'library': { > 'values': ['static', 'shared'], > 'default': 'static', > @@ -337,6 +345,8 @@ > return False > if not IsLegal(env, 'sample', ["shell", "process"]): > return False > + if env['os'] == 'win32' and env['library'] == 'shared' and env['prof'] == > 'on': > + Abort("Profiling on windows only supported for static library.") > for (name, option) in SIMPLE_OPTIONS.iteritems(): > if (not option.get('default')) and (name not in ARGUMENTS): > message = ("A value for option %s must be specified (%s)." % > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
