LGTM On Thu, Sep 25, 2008 at 2:59 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Mads Ager, > > Description: > > Fixed problem where the test framework would assume that .svn was a > test suite and then fail. > > Please review this at http://codereview.chromium.org/4082 > > Affected files: > M tools/test.py > > > Index: tools/test.py > diff --git a/tools/test.py b/tools/test.py > index > 660ee37c00b510bdece659125b5d374ec3e0c269..1632895c0d36afe8b5c5f413344f155821a902ec > 100755 > --- a/tools/test.py > +++ b/tools/test.py > @@ -30,7 +30,7 @@ > import imp > import optparse > import os > -from os.path import join, dirname, abspath, basename, isdir > +from os.path import join, dirname, abspath, basename, isdir, exists > import platform > import re > import signal > @@ -1064,7 +1064,9 @@ BUILT_IN_TESTS = ['mjsunit', 'cctest'] > > > def GetSuites(test_root): > - return [ f for f in os.listdir(test_root) if isdir(join(test_root, f)) ] > + def IsSuite(path): > + return isdir(path) and exists(join(path, 'testcfg.py')) > + return [ f for f in os.listdir(test_root) if IsSuite(join(test_root, f)) > ] > > > def Main(): > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
