I don't think it's on the ARM, we don't push literals directly there. It was part of a bigger change that got lost somehow.
On Thu, Oct 2, 2008 at 4:17 PM, Kasper Lund <[EMAIL PROTECTED]> wrote: > LGTM. Wasn't this a part of an earlier and bigger change? Do we have > something like this on ARM? > > On Thu, Oct 2, 2008 at 4:09 PM, <[EMAIL PROTECTED]> wrote: > > Reviewers: Kasper Lund, > > > > Description: > > Print one line when pushing an immediate followed by a pop is > > eliminated. > > > > Please review this at http://codereview.chromium.org/6078 > > > > Affected files: > > M src/assembler-ia32.cc > > > > > > Index: src/assembler-ia32.cc > > =================================================================== > > --- src/assembler-ia32.cc (revision 411) > > +++ src/assembler-ia32.cc (working copy) > > @@ -475,6 +475,9 @@ > > // change to > > // 31c0 xor eax,eax > > last_pc_ = NULL; > > + if (FLAG_print_push_pop_elimination) { > > + PrintF("%d push/pop (imm->reg) eliminated\n", pc_offset()); > > + } > > return; > > } else { > > // 6a00 push 0xXX > > @@ -495,6 +498,9 @@ > > // b8XX000000 mov eax,0x000000XX > > } > > last_pc_ = NULL; > > + if (FLAG_print_push_pop_elimination) { > > + PrintF("%d push/pop (imm->reg) eliminated\n", pc_offset()); > > + } > > return; > > } > > } else if (instr == 0x68 && dst.is(eax)) { // push of immediate 32 > bit > > @@ -504,6 +510,9 @@ > > last_pc_ = NULL; > > // change to > > // b8XXXXXXXX mov eax,0xXXXXXXXX > > + if (FLAG_print_push_pop_elimination) { > > + PrintF("%d push/pop (imm->reg) eliminated\n", pc_offset()); > > + } > > return; > > } > > > > > > > > > -- Google Denmark ApS CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
