Thanks. Committed.
http://codereview.chromium.org/6223/diff/1/10 File src/array.js (right): http://codereview.chromium.org/6223/diff/1/10#newcode932 Line 932: InstallFunctions($Array.prototype, DONT_ENUM, new $Array( Right. An array literal will not work. http://codereview.chromium.org/6223/diff/1/7 File src/date-delay.js (right): http://codereview.chromium.org/6223/diff/1/7#newcode645 Line 645: }; No need for a separate round of reviews for that. I have removed the semicolons I could find. http://codereview.chromium.org/6223/diff/1/9 File src/messages.js (right): http://codereview.chromium.org/6223/diff/1/9#newcode654 Line 654: DefineError('Error', function Error(msg) { }); The (msg) part is gone. It is replaced anyway. I'm now getting the name from the function passed in. http://codereview.chromium.org/6223/diff/1/6 File src/regexp-delay.js (right): http://codereview.chromium.org/6223/diff/1/6#newcode342 Line 342: function NoOpSetter(ignored) {}; Done. http://codereview.chromium.org/6223/diff/1/6#newcode363 Line 363: // A local scope to hide the loop index i. True, none of the local scope are needed here since we are in a function scope already. Removed. http://codereview.chromium.org/6223/diff/1/12 File src/string.js (right): http://codereview.chromium.org/6223/diff/1/12#newcode1 Line 1: // Copyright 2006-2008 the V8 project authors. All rights reserved. I agree. I'll do that in a separate change list. http://codereview.chromium.org/6223/diff/1/4 File src/v8natives.js (right): http://codereview.chromium.org/6223/diff/1/4#newcode78 Line 78: return $floor(string); Done. http://codereview.chromium.org/6223 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
