Lgtm.

On Fri, Oct 3, 2008 at 10:56 AM,  <[EMAIL PROTECTED]> wrote:
> Reviewers: Christian Plesner Hansen,
>
> Description:
> Updated the snapshot builder to reflect the removed extensions in
> http://codereview.chromium.org/6233.
>
> Please review this at http://codereview.chromium.org/6440
>
> Affected files:
>  M     src/mksnapshot.cc
>
>
> Index: src/mksnapshot.cc
> ===================================================================
> --- src/mksnapshot.cc   (revision 416)
> +++ src/mksnapshot.cc   (working copy)
> @@ -159,12 +159,8 @@
>   v8::V8::SetCounterFunction(counter_callback);
>   v8::HandleScope scope;
>
> -  const int kExtensionCount = 5;
> -  const char* extension_list[kExtensionCount] = { "v8/print",
> -                                                  "v8/load",
> -                                                  "v8/quit",
> -                                                  "v8/version",
> -                                                  "v8/gc" };
> +  const int kExtensionCount = 1;
> +  const char* extension_list[kExtensionCount] = { "v8/gc" };
>   v8::ExtensionConfiguration extensions(kExtensionCount, extension_list);
>   v8::Context::New(&extensions);
>
>
>
>

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to