LGTM with a few comments:
http://codereview.chromium.org/6234/diff/1/2 File src/debug.h (right): http://codereview.chromium.org/6234/diff/1/2#newcode473 Line 473: // Enter the debugger. Maybe put a better comment here? It's really a helper class that supports entering the debugger, right? http://codereview.chromium.org/6234/diff/1/2#newcode496 Line 496: } This looks weird. Remove else? http://codereview.chromium.org/6234/diff/1/2#newcode501 Line 501: // restore to the previous break state. Capitalize comment. http://codereview.chromium.org/6234/diff/1/2#newcode507 Line 507: inline bool Failed() { return load_failed; } Rename to DidLoadFail? http://codereview.chromium.org/6234/diff/1/2#newcode514 Line 514: bool load_failed; // Did the debugger fail to load? load_failed_ http://codereview.chromium.org/6234/diff/1/2#newcode515 Line 515: SaveContext save; // Saves previous context. save_ http://codereview.chromium.org/6234/diff/1/4 File src/runtime.cc (right): http://codereview.chromium.org/6234/diff/1/4#newcode3114 Line 3114: EnterDebugger debugger; Does entering the debugger using EnterDebugger require a HandleScope? It probably does... http://codereview.chromium.org/6234 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
