On Sat, Oct 4, 2008 at 1:56 PM, Christian Plesner Hansen <[EMAIL PROTECTED]> wrote: > > Sorry, I accidentally submitted this without addressing your comments. > > I'll rename it to haystack. > > The code does actually break out as soon as a special character has > been seen, it's part of the condition of the for loop.
It's probably premature optimization to point out that putting the whole thing in an if, adding the break and removing the condition from the loop would be more efficient. > > On Thu, Oct 2, 2008 at 3:17 PM, Erik Corry <[EMAIL PROTECTED]> wrote: >> For some reason the comments I typed into Rietveld are not in this mail. >> Seems I haven't quite mastered the use yet. >> >> Comments were that subject should be called haystack and you might as well >> break when you have found a regexp special character. >> >> On Thu, Oct 2, 2008 at 3:14 PM, <[EMAIL PROTECTED]> wrote: >>> >>> On 2008/10/02 12:00:05, Christian Plesner Hansen wrote: >>>> >>> >>> Seems a little strange that we only use KMP for needles > 100 >>> characters. That's probably very rare. >>> >>> LGTM >>> >>> http://codereview.chromium.org/6076 >> >> >> >> -- >> Erik Corry, Software Engineer >> Google Denmark ApS. CVR nr. 28 86 69 84 >> c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, >> Denmark. >> >> > >> > > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
