Greatness in a nutshell. LGTM. On Mon, Oct 6, 2008 at 2:40 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Description: > The constructor properties on the prototypes of error objects should > not be enumerable. > > Please review this at http://codereview.chromium.org/6270 > > Affected files: > M src/messages.js > > > Index: src/messages.js > =================================================================== > --- src/messages.js (revision 435) > +++ src/messages.js (working copy) > @@ -639,8 +639,8 @@ > // prototype of 'Error' must be as default: new Object(). > if (name != 'Error') %FunctionSetPrototype(f, new $Error()); > %FunctionSetInstanceClassName(f, 'Error'); > + %SetProperty(f.prototype, 'constructor', f, DONT_ENUM); > f.prototype.name = name; > - f.prototype.constructor = f; > %SetCode(f, function(m) { > if (%IsConstructCall()) { > if (!IS_UNDEFINED(m)) this.message = ToString(m); > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
