LGTM. On Tue, Oct 7, 2008 at 9:04 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Description: > Removed some debug code related to issue 1308895 which was fixed in CL > http://codereview.chromium.org/6271. > > Please review this at http://codereview.chromium.org/6299 > > Affected files: > M src/objects.cc > > > Index: src/objects.cc > =================================================================== > --- src/objects.cc (revision 448) > +++ src/objects.cc (working copy) > @@ -137,19 +137,6 @@ > } else if (IsBoolean()) { > holder = global_context->boolean_function()->instance_prototype(); > } > -#ifdef DEBUG > - // Used to track outstanding bug #1308895. > - // TODO(1308895) Remove when bug is fixed. > - if (holder == NULL) { > - PrintF("\nName being looked up: "); > - name->Print(); > - PrintF("\nThis (object name is looked up in: "); > - this->Print(); > - if (IsScript()) { > - PrintF("IsScript() returns true.\n"); > - } > - } > -#endif > ASSERT(holder != NULL); // cannot handle null or undefined. > JSObject::cast(holder)->Lookup(name, result); > } > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
