LGTM. On Tue, Oct 7, 2008 at 12:30 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Description: > - Fixed the parameter pasing to SharedStoreIC_ExtendStorage > for keyed store ic. > > > Please review this at http://codereview.chromium.org/6303 > > Affected files: > M src/ic-ia32.cc > > > Index: src/ic-ia32.cc > =================================================================== > --- src/ic-ia32.cc (revision 456) > +++ src/ic-ia32.cc (working copy) > @@ -754,17 +754,18 @@ > void KeyedStoreIC::GenerateExtendStorage(MacroAssembler* masm) { > // ----------- S t a t e ------------- > // -- eax : value > + // -- ecx : transition map > // -- esp[0] : return address > // -- esp[4] : key > // -- esp[8] : receiver > // ----------------------------------- > > // Move the return address below the arguments. > - __ pop(ecx); > + __ pop(ebx); > __ push(Operand(esp, 1 * kPointerSize)); > - __ push(Operand(esp, 1 * kPointerSize)); > + __ push(ecx); > __ push(eax); > - __ push(ecx); > + __ push(ebx); > > // Do tail-call to runtime routine. > __ TailCallRuntime( > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
