LGTM
http://codereview.chromium.org/6533/diff/1/3 File src/runtime.cc (right): http://codereview.chromium.org/6533/diff/1/3#newcode1036 Line 1036: // Significant bits taken from that character to use in bad-character 'that' seems to be a dangling reference http://codereview.chromium.org/6533/diff/1/3#newcode1056 Line 1056: SmartPointer<byte> bad_char_map(NewArray<byte>(kBMHBadCharCount)); May as well be static for speed! http://codereview.chromium.org/6533/diff/1/3#newcode1062 Line 1062: for(int i = p < m ? m - p : 0; i < m - 1; i++) { Single-character variable overload here! http://codereview.chromium.org/6533/diff/1/3#newcode1063 Line 1063: pchar c = pattern[i]; if (sizeof(schar) == 1 && c > 255) return -1; http://codereview.chromium.org/6533/diff/1/3#newcode1147 Line 1147: // For small searches, KMP is not worth the setup overhead. KMP? http://codereview.chromium.org/6533 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
