Hi Eric I assume you will fix the real issues so the stack tracing with preallocated memory works regardless of the allocated size.
Thanks, Lars On Tue, Oct 7, 2008 at 3:23 PM, Erik Corry <[EMAIL PROTECTED]> wrote: > > LGTM > > On Tue, Oct 7, 2008 at 3:01 PM, <[EMAIL PROTECTED]> wrote: >> >> Reviewers: Kasper Lund, >> >> Description: >> - Changed the stack size in PreallocatedMemoryThread from 16K to 32K >> to make flexo happy. >> >> >> Please review this at http://codereview.chromium.org/6537 >> >> Affected files: >> M src/top.cc >> >> >> Index: src/top.cc >> =================================================================== >> --- src/top.cc (revision 461) >> +++ src/top.cc (working copy) >> @@ -119,7 +119,7 @@ >> // When the thread starts running it will allocate a fixed number of >> bytes >> // on the stack and publish the location of this memory for others to >> use. >> void Run() { >> - EmbeddedVector<char, 16 * 1024> local_buffer; >> + EmbeddedVector<char, 32 * 1024> local_buffer; >> >> // Initialize the buffer with a known good value. >> OS::StrNCpy(local_buffer, "Trace data was not generated.\n", >> >> >> >> > >> > > > > -- > Erik Corry, Software Engineer > Google Denmark ApS. CVR nr. 28 86 69 84 > c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 > Copenhagen K, Denmark. > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
