LGTM. Could you fix the behaior spelling too (in the comment)? On Tue, Oct 7, 2008 at 2:00 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Description: > -Fixed regression in S15.5.5.1_A5.js. > I eliminated the fast case check in ToPrimitive. > > > Please review this at http://codereview.chromium.org/6534 > > Affected files: > M src/runtime.js > > > Index: src/runtime.js > =================================================================== > --- src/runtime.js (revision 460) > +++ src/runtime.js (working copy) > @@ -396,7 +396,6 @@ > function ToPrimitive(x, hint) { > // Fast case check. > if (IS_STRING(x)) return x; > - if ((hint != NUMBER_HINT) && %IsStringClass(x)) return %_ValueOf(x); > // Normal behaior. > if (!IS_OBJECT(x) && !IS_FUNCTION(x)) return x; > if (x == null) return x; // check for null, undefined > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
