http://codereview.chromium.org/6269/diff/1/5 File src/runtime.cc (right):
http://codereview.chromium.org/6269/diff/1/5#newcode935 Line 935: for(;;) { On 2008/10/06 12:47:19, Christian Plesner Hansen wrote: > Flat strings are relatively simple in structure so it should be possible to get > a hold of the string contents with straight-line code. Done. http://codereview.chromium.org/6269/diff/1/5#newcode1006 Line 1006: Vector<const schar> string, On 2008/10/06 12:47:19, Christian Plesner Hansen wrote: > This argument should be on the same line as the function header with the > remaining arguments below it, indented to the same level. Done. http://codereview.chromium.org/6269/diff/1/5#newcode1009 Line 1009: for (int i = start_index, n = string.length(); i < n; i++) { On 2008/10/06 12:47:19, Christian Plesner Hansen wrote: > I would move the declaration of n out before the loop. I consider for (int i = ..., n = ...; i<n; i++) an idiom, and prefer to limit the scope of n to where it's needed. http://codereview.chromium.org/6269/diff/1/5#newcode1060 Line 1060: int length = pattern.length(); On 2008/10/06 12:47:19, Christian Plesner Hansen wrote: > Isn't this identical to pattern_length? Indeed, it should be removed. Done. http://codereview.chromium.org/6269/diff/1/5#newcode1122 Line 1122: sub->TryFlatten(); Doesn't handle failure to flatten. Changed to the handle based FlattenString. http://codereview.chromium.org/6269 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
