This causes a significant performance regression on some tests. I'm profiling it to find out where, but keep this in mind while reading the code - you may spot the problem.
On Tue, Oct 7, 2008 at 12:41 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: bak, > > Message: > Here is the last of the changes to AddProperty and descriptor arrays. > > Description: > This change rewrites some of the code to add properties to an object. > It removes the ReplaceConstantFunction code, and replaces it with > new ConvertDescriptorToField code, that is also used in other places. > Functions CopyRemove and CopyReplace on DescriptorArray are removed. > Function AddFastProperty is simplified by removing the > CONSTANT_TRANSITION case. > > Please review this at http://codereview.chromium.org/6528 > > Affected files: > M src/objects.cc > M src/objects.h > > > -- We can IMAGINE what is not --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
