Good point.

The amazing this is that I was able to fix this just by doing refactor
rename on the method declarations.  Eclipse CDT for the win!

On Wed, Oct 8, 2008 at 2:59 PM,  <[EMAIL PROTECTED]> wrote:
>
> http://codereview.chromium.org/6342/diff/1/8
> File src/objects.h (right):
>
> http://codereview.chromium.org/6342/diff/1/8#newcode3168
> Line 3168: inline int AsciiStringSize(Map* map);
> Needs renaming
>
> http://codereview.chromium.org/6342/diff/1/8#newcode3179
> Line 3179: inline void AsciiStringReadBlockIntoBuffer(ReadBlockBuffer*
> buffer,
> Ditto
>
> http://codereview.chromium.org/6342/diff/1/8#newcode3182
> Line 3182: inline const unibrow::byte* AsciiStringReadBlock(unsigned*
> remaining,
> Ditto
>
> http://codereview.chromium.org/6342/diff/1/8#newcode3203
> Line 3203: const uint16_t* TwoByteStringGetData(unsigned start);
> Ditto
>
> http://codereview.chromium.org/6342/diff/1/8#newcode3211
> Line 3211: inline int TwoByteStringSize(Map* map);
> Ditto
>
> http://codereview.chromium.org/6342/diff/1/8#newcode3222
> Line 3222: inline void TwoByteStringReadBlockIntoBuffer(ReadBlockBuffer*
> buffer,
> Ditto
>
> http://codereview.chromium.org/6342
>

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to