Good suggestion. I will put it in this change list and look for other opportunities.
On Fri, Oct 10, 2008 at 2:53 PM, <[EMAIL PROTECTED]> wrote: > I am sure there are more situations where a Pop() with no target would > be useful, I just found a couple that just jumped out at me. > > > > http://codereview.chromium.org/7076/diff/1/3 > File src/codegen-ia32.cc (right): > > http://codereview.chromium.org/7076/diff/1/3#newcode304 > Line 304: frame_->Pop(eax); // Value is no longer needed. > If the value is really no longer needed the there should also be a Pop() > operation that takes no target register and just pops the value from the > virtual frame without causing memory traffic. In the current > implementation this could translate to add(sp, sp, 4). > > I understand that Pop() is equivalent to Drop(1), but it is sort of more > readable in these situations. > > http://codereview.chromium.org/7076/diff/1/3#newcode1394 > Line 1394: frame_->Pop(eax); // Pop(no_reg); > Another potential use of Pop()... > > http://codereview.chromium.org/7076/diff/1/3#newcode1405 > Line 1405: frame_->Pop(eax); // remove the lingering expression result > from the top of stack > And another potential use of Pop()... > > > http://codereview.chromium.org/7076 > -- Google Denmark ApS CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
